Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release: always use service user for git ops #24546

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

gulducat
Copy link
Member

@gulducat gulducat commented Nov 22, 2024

We are shoring up our user and bot accesses, and this seems to be our only usage of the github-actions bot.

These were the commits that have been flagged as needing adjustment:

workflows/release.yml
145:            git commit --message "Generate files for ${{ github.event.inputs.version }} release"
212:            git commit --message 'Prepare for next release'

We may later discover other of our repos that need a similar treatment, if they've just not been run during this information-gathering time, but at present this is the only known case. Our CE->ENT merge workflow in the ENT repo is already set up properly.

@gulducat gulducat added theme/ci backport/ent/1.7.x+ent Changes are backported to 1.7.x+ent backport/ent/1.8.x+ent Changes are backported to 1.8.x+ent backport/1.9.x backport to 1.9.x release line labels Nov 22, 2024
@gulducat gulducat requested review from a team as code owners November 22, 2024 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/ent/1.7.x+ent Changes are backported to 1.7.x+ent backport/ent/1.8.x+ent Changes are backported to 1.8.x+ent backport/1.9.x backport to 1.9.x release line theme/ci
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant